[test] Add tests for strutil.DeepCloneJSON#7232
Merged
Merged
Conversation
Add comprehensive table-driven tests for DeepCloneJSON covering: - Primitive pass-through (nil, string, float64, bool) - Empty and flat map cloning - Empty and flat slice cloning - Nested map and slice deep cloning - Deep clone independence (mutations to clone don't affect original) - Mixed structures (maps containing slices, slices containing maps) - Deeply nested structures - Null/nil values within collections Improves strutil package coverage from 88.2% to 100.0%. DeepCloneJSON specifically: 0% → 100%. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This was referenced Jun 9, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Adds comprehensive unit tests for internal/strutil.DeepCloneJSON, covering primitive pass-through, map/slice cloning, mixed/nested structures, and clone-independence to eliminate the last uncovered function in internal/strutil.
Changes:
- Introduces a new
TestDeepCloneJSONsuite with subtests for primitives, empty/flat/nested maps and slices, and mixed recursion (map↔slice nesting). - Verifies deep-clone independence by mutating cloned nested structures and asserting originals are unaffected.
Show a summary per file
| File | Description |
|---|---|
| internal/strutil/deepclone_test.go | Adds full test coverage for DeepCloneJSON, including deep-independence checks across nested map/slice structures. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test Coverage Improvement: DeepCloneJSON
Function Analyzed
internal/strutilDeepCloneJSONWhy This Function?
DeepCloneJSONwas the only function in the codebase with 0% coverage among testable packages. It has meaningful complexity: a recursive type-switch with three distinct branches (map cloning, slice cloning, and primitive pass-through), and the correctness of deep-clone independence is non-trivial to verify without explicit tests.Tests Added
nil,string,float64,bool(true and false)nilvalues within maps and slicesCoverage Report
Test Execution
All 21 tests pass:
Generated by Test Coverage Improver
Next run will target the next most complex under-tested function
Warning
Firewall blocked 7 domains
The following domains were blocked by the firewall during workflow execution:
go.opentelemetry.iogo.yaml.ingolang.orggoogle.golang.orggopkg.inproxy.golang.orgreleaseassets.githubusercontent.comSee Network Configuration for more information.